Skip to content

[py] implement relative locator for find_element #9902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

[py] implement relative locator for find_element #9902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef19fe
[py] implement relative locator for find_element
titusfortner Oct 12, 2021
b16bd96
Merge branch 'trunk' into py_relative
AutomatedTester Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions py/selenium/webdriver/remote/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,6 +1220,9 @@ def find_element(self, by=By.ID, value=None) -> WebElement:

:rtype: WebElement
"""
if isinstance(by, RelativeBy):
return self.find_elements(by=by, value=value)[0]

if by == By.ID:
by = By.CSS_SELECTOR
value = '[id="%s"]' % value
Expand Down
9 changes: 9 additions & 0 deletions py/test/selenium/webdriver/support/relative_by_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@
from selenium.webdriver.support.relative_locator import with_tag_name, locate_with


def test_should_be_able_to_find_first_one(driver, pages):
pages.load("relative_locators.html")
lowest = driver.find_element(By.ID, "below")

el = driver.find_element(with_tag_name("p").above(lowest))

assert el.get_attribute('id') == "mid"


def test_should_be_able_to_find_elements_above_another(driver, pages):
pages.load("relative_locators.html")
lowest = driver.find_element(By.ID, "below")
Expand Down