Skip to content

install_addon() didn't take into account dir paths with trailing slashes #13694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2024
Merged

install_addon() didn't take into account dir paths with trailing slashes #13694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae27abc
install_addon() didn't take into account dir paths with trailing slashes
jkbzh Mar 14, 2024
7ebef21
replacing os.rpath with os.path.normpath()
jkbzh Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion py/selenium/webdriver/firefox/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ def install_addon(self, path, temporary=False) -> str:

if os.path.isdir(path):
fp = BytesIO()
path_root = len(path) + 1 # account for trailing slash
# filter all trailing slash found in path
path = os.path.normpath(path)
# account for trailing slash that will be added by os.walk()
path_root = len(path) + 1
with zipfile.ZipFile(fp, "w", zipfile.ZIP_DEFLATED) as zipped:
for base, _, files in os.walk(path):
for fyle in files:
Expand Down