#2957 Fixed tolerations indent for keda patched jobs

[anwaramoon]

Description

Upgrade "selenium-grid" failed: post-upgrade hooks failed: warning: Hook post-upgrade selenium-grid/templates/patch-keda/delete-keda-objects-job.yaml

Tolerations indent is wrong and causing invalid job spec and upgrade failure

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Style Consistency There is an extra space before the colon in the rendered key tolerations :. Consider removing it to match common YAML/Helm style (tolerations:) across the chart. tolerations : {{ toYaml . | nindent 12 }} {{- end }} Style Consistency Same extra space before the colon in tolerations :. Align with standard formatting (tolerations:). tolerations : {{ toYaml . | nindent 12 }} {{- end }}

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Move tolerations to the pod spec Move the tolerations block from the container specification to be a direct child of the pod specification, adjusting indentation accordingly, to comply with the Kubernetes API schema. charts/selenium-grid/templates/patch-keda/delete-keda-objects-job.yaml [39-41] -{{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} - tolerations : {{ toYaml . | nindent 12 }} - {{- end }} +... (code to be moved) ... + {{- end }} + {{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} + tolerations: {{ toYaml . | nindent 8 }} + {{- end }} + volumes: + - name: cleanup-script [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a critical issue where tolerations are misplaced in the container spec, which would create an invalid Kubernetes manifest. The proposed fix is accurate and necessary for the chart to function correctly.	High
Update

[anwaramoon]

@VietND96 Tolerations added in my original PR #2912 are causing helm upgrade failure for the latest chart version. This PR will fix the indent issue.