Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Sep 6, 2025

User description

This PR contains the CHANGELOG for Node/Standalone edge with specific browser versions: [95, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138]


PR Type

Other


Description

  • Update build date from 20250808 to 20250828

  • Add Edge version 139 to browser matrix

  • Update changelog files for Edge versions 114-138

  • Add Edge version 139 to workflow configuration


Diagram Walkthrough

flowchart LR
  A["Workflow Config"] --> B["Browser Matrix"]
  A --> C["Edge Versions 114-138"]
  C --> D["Build Date Update"]
  B --> E["Add Edge 139"]
  D --> F["20250808 → 20250828"]
Loading

File Walkthrough

Relevant files
Configuration changes
1 files
release-edge-versions.yml
Add Edge version 139 to workflow                                                 
+1/-1     
Documentation
19 files
edge_114.md
Update build date to 20250828                                                       
+15/-15 
edge_115.md
Update build date to 20250828                                                       
+15/-15 
edge_116.md
Update build date to 20250828                                                       
+15/-15 
edge_117.md
Update build date to 20250828                                                       
+15/-15 
edge_118.md
Update build date to 20250828                                                       
+15/-15 
edge_119.md
Update build date to 20250828                                                       
+15/-15 
edge_120.md
Update build date to 20250828                                                       
+15/-15 
edge_121.md
Update build date to 20250828                                                       
+15/-15 
edge_122.md
Update build date to 20250828                                                       
+15/-15 
edge_123.md
Update build date to 20250828                                                       
+15/-15 
edge_124.md
Update build date to 20250828                                                       
+15/-15 
edge_125.md
Update build date to 20250828                                                       
+15/-15 
edge_126.md
Update build date to 20250828                                                       
+15/-15 
edge_127.md
Update build date to 20250828                                                       
+15/-15 
edge_128.md
Update build date to 20250828                                                       
+15/-15 
edge_129.md
Update build date to 20250828                                                       
+15/-15 
edge_130.md
Update build date to 20250828                                                       
+15/-15 
edge_131.md
Update build date to 20250828                                                       
+15/-15 
edge_132.md
Update build date to 20250828                                                       
+15/-15 
Additional files
7 files
edge_133.md +15/-15 
edge_134.md +15/-15 
edge_135.md +15/-15 
edge_136.md +15/-15 
edge_137.md +15/-15 
edge_138.md +15/-15 
browser-matrix.yml +1/-1     

Browser versions: [95, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138]
Copy link
Contributor

qodo-merge-pro bot commented Sep 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Matrix Default

The default browser versions list was expanded to include 139; confirm consumers actually want 95 and 114–139 all built by default, or consider keeping the list smaller and passing explicit versions via dispatch to avoid long CI runs and rate limits.

  default: '[95, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139]'
push-image:
Version Pin

New Edge pin for 140 is added; verify that this exact package version is available across all targeted platforms and mirrors to prevent CI failures, and consider aligning with how 139 is pinned (consistency of format and update cadence).

EDGE_VERSION: microsoft-edge-stable=140.0.3485.54-1
CHROME_VERSION: google-chrome-stable=140.0.7339.80-1

Copy link
Contributor

qodo-merge-pro bot commented Sep 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Unify browser version matrix

The workflow, changelogs, and test matrix are out of sync (workflow builds 139,
changelogs stop at 138, tests pin 140), creating multiple sources of truth that
can yield inconsistent releases and CI results. Centralize the browser-version
matrix in a single authoritative file and have workflows, changelog generation,
and tests consume it to ensure consistent updates and prevent drift.

Examples:

.github/workflows/release-edge-versions.yml [34]
        default: '[95, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139]'
tests/build-backward-compatible/browser-matrix.yml [12]
      EDGE_VERSION: microsoft-edge-stable=140.0.3485.54-1

Solution Walkthrough:

Before:

# .github/workflows/release-edge-versions.yml
# Workflow default is updated to include version 139
...
  browser-versions:
    default: '[..., 138, 139]'

# CHANGELOG/4.35.0/
# Changelog files are manually updated, but only up to edge_138.md.
# No file for 139 is created or updated.

# tests/build-backward-compatible/browser-matrix.yml
# A separate test matrix pins a specific build for version 140.
matrix:
  browser:
    '140':
      EDGE_VERSION: microsoft-edge-stable=140.0.3485.54-1

After:

# centralized-browser-matrix.yml (New single source of truth)
edge:
  '138':
    full_version: '138.0.3351.121'
    # ... other metadata
  '139':
    # ... version 139 metadata
  '140':
    full_version: '140.0.3485.54-1'

# .github/workflows/release-edge-versions.yml
# Workflow reads from the centralized file to generate its matrix
jobs:
  build:
    strategy:
      matrix:
        browser-version: ${{ fromJson(steps.read_matrix.outputs.edge_versions) }}

# Test configurations and changelog generation scripts would also
# consume centralized-browser-matrix.yml to ensure consistency.
Suggestion importance[1-10]: 9

__

Why: This suggestion correctly identifies a significant architectural flaw where browser versions are managed in multiple locations, leading to inconsistencies and high maintenance, which this PR's manual changes highlight.

High
  • More

@VietND96 VietND96 changed the base branch from trunk to browser-node-chrome-changelog September 6, 2025 08:19
@VietND96 VietND96 merged commit 6ab6400 into browser-node-chrome-changelog Sep 6, 2025
29 checks passed
@VietND96 VietND96 deleted the browser-node-edge-changelog branch September 6, 2025 08:20
VietND96 pushed a commit that referenced this pull request Sep 6, 2025
…4.35.0 (#2948)

* [ci] Upload CHANGELOG for Node/Standalone chrome version with Grid 4.35.0

Browser versions: [95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139]

* [ci] CHANGELOG for Node/Standalone edge browser versions with Grid 4.35.0 (#2949)

[ci] Upload CHANGELOG for Node/Standalone edge version with Grid 4.35.0

Browser versions: [95, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138]

Co-authored-by: Selenium CI Bot <[email protected]>

* [ci] CHANGELOG for Node/Standalone firefox browser versions with Grid 4.35.0 (#2950)

[ci] Upload CHANGELOG for Node/Standalone firefox version with Grid 4.35.0

Browser versions: [98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141]

Co-authored-by: Selenium CI Bot <[email protected]>

---------

Co-authored-by: Selenium CI Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants