-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Fix deploy all browsers in one Node/Standalone image #2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
1d13fbe
to
f5f8b7a
Compare
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Fix Docker build logic for all-browsers images
Separate platform-specific browser builds (amd64 vs arm64)
Replace Chromium with Chrome for amd64 platform
Add proper case handling for arm64 builds
Diagram Walkthrough
File Walkthrough
Makefile
Fix multi-platform all-browsers Docker build logic
Makefile