Skip to content

Docker: Use GreedySlotSelector in Hub and Standalone #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ ENV SE_BIND_HOST="false" \
SE_SERVER_PROTOCOL="http" \
# Boolean value, maps "--reject-unsupported-caps"
SE_REJECT_UNSUPPORTED_CAPS="false" \
SE_DISTRIBUTOR_SLOT_SELECTOR="org.openqa.selenium.grid.distributor.selector.GreedySlotSelector" \
SE_OTEL_JAVA_GLOBAL_AUTOCONFIGURE_ENABLED="true" \
SE_OTEL_TRACES_EXPORTER="otlp" \
SE_SUPERVISORD_LOG_LEVEL="info" \
Expand Down
2 changes: 1 addition & 1 deletion ENV_VARIABLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,4 @@
| SE_VIDEO_MAXRATE | | | |
| SE_NODE_DELETE_SESSION_ON_UI | true | Enable capability to support deleting session on Grid UI | --delete-session-on-ui |
| SE_UPDATE_CHROME_COMPONENTS | | Applicable for node-chrome, standalone-chrome (arch linux/amd64). Update the latest version of Chrome and ChromeDriver at the beginning of the container startup. Read more: [#2872](https://github.com/SeleniumHQ/docker-selenium/pull/2872) | |
| SE_DISTRIBUTOR_SLOT_SELECTOR | | Full class name of non-default slot selector. This is used to select a slot in a Node once the Node has been matched. | --slot-selector |
| SE_DISTRIBUTOR_SLOT_SELECTOR | org.openqa.selenium.grid.distributor.selector.GreedySlotSelector | Full class name of non-default slot selector. This is used to select a slot in a Node once the Node has been matched. Switch to default, use class name `org.openqa.selenium.grid.distributor.selector.DefaultSlotSelector` | --slot-selector |
1 change: 1 addition & 0 deletions charts/selenium-grid/CONFIGURATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
| autoscaling.patchObjectFinalizers.imagePullSecret | string | `""` | Custom pull secret for container in patch job |
| autoscaling.patchObjectFinalizers.resources | object | `{"limits":{"cpu":"200m","memory":"500Mi"},"requests":{"cpu":"100m","memory":"200Mi"}}` | Define resources for container in patch job |
| autoscaling.patchObjectFinalizers.nodeSelector | object | `{}` | Node selector for the patch job |
| autoscaling.patchObjectFinalizers.tolerations | list | `[]` | Tolerations for the patch job |
| autoscaling.scaledOptions | object | `{"maxReplicaCount":24,"minReplicaCount":0,"pollingInterval":20}` | Options for KEDA scaled resources (keep only common options used for both ScaledJob and ScaledObject) |
| autoscaling.scaledOptions.minReplicaCount | int | `0` | Minimum number of replicas |
| autoscaling.scaledOptions.maxReplicaCount | int | `24` | Maximum number of replicas |
Expand Down
2 changes: 2 additions & 0 deletions charts/selenium-grid/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,8 @@ autoscaling:
memory: 500Mi
# -- Node selector for the patch job
nodeSelector: {}
# -- Tolerations for the patch job
tolerations: []
# -- Options for KEDA scaled resources (keep only common options used for both ScaledJob and ScaledObject)
scaledOptions:
# Don't define `triggers` config here, it will apply the same to all node types. Instead, define it under `scaledOptions` of different node type
Expand Down
3 changes: 2 additions & 1 deletion scripts/generate_list_env_vars/description.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -479,5 +479,6 @@
cli: ''
- name: SE_DISTRIBUTOR_SLOT_SELECTOR
description: Full class name of non-default slot selector. This is used to select
a slot in a Node once the Node has been matched.
a slot in a Node once the Node has been matched. Switch to default, use class
name `org.openqa.selenium.grid.distributor.selector.DefaultSlotSelector`
cli: --slot-selector
2 changes: 1 addition & 1 deletion scripts/generate_list_env_vars/value.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
- name: SE_DISTRIBUTOR_PORT
default: '5553'
- name: SE_DISTRIBUTOR_SLOT_SELECTOR
default: ''
default: org.openqa.selenium.grid.distributor.selector.GreedySlotSelector
- name: SE_DRAIN_AFTER_SESSION_COUNT
default: '0'
- name: SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP
Expand Down
Loading