[🐛 Bug]: Node: Disable/Enable VNC view only (or GUI interaction)

[alramostpt]

What happened?

Documentation explain the enable/disable of GUI interactions with the use of the env var as follows:
If you want to run VNC in view-only mode you can set the environment variable SE_VNC_VIEW_ONLY=1.

docker-selenium/README.md

Line 1666 in cf0c839

If you want to run VNC in view-only mode you can set the environment variable `SE_VNC_VIEW_ONLY=1`.

But flag for that settings works as follow:
if [ ! -z $VNC_VIEW_ONLY ];

docker-selenium/NodeBase/start-vnc.sh

Line 25 in cf0c839

if [ ! -z $VNC_VIEW_ONLY ]; then

Where this IF operation enables the view only mode when this env contains any value instead of the documented method of setting that value to 1.

This creates an unintended behavior when the value is set to 0 expecting to disable the view only mode.

Command used to start Selenium Grid with Docker (or Kubernetes)

N/A (any)

Relevant log output

N/A

Operating System

Any

Docker Selenium version (image tag)

Any

Selenium Grid chart version (chart version)

Any

[github-actions]

@alramostpt, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[VietND96]

The value 0, 1 seems not make sense to me. Since in bash, 0 stands for true, and of course it is correct when comparing as string. I am preferred to true or false.
However, to avoid regression breaking, I keep comparing with true or 1

[alramostpt]

The value 0, 1 seems not make sense to me. Since in bash, 0 stands for true, and of course it is correct when comparing as string. I am preferred to true or false. However, to avoid regression breaking, I keep comparing with true or 1

Reaching the conclusion of doing nothing to avoid regression breaking with even updating documentation to clarify expected behavior seems non-sense to me. It seems that the real intention done here is just to close this issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.