[🐛 Bug]: Resource Limits missing for pre-pull InitContainer

[Koeppchen]

What happened?

With 44d9224 an Init Container without resource limits was added. All containers should have resource limits.
Changing templates/_helpers.tpl initContainer to

initContainers:
  - name: "pre-puller-{{ .name }}"
    image: {{ printf "%s/%s:%s" $nodeImageRegistry .node.imageName $nodeImageTag }}
    command: ["bash", "-c", "'true'"]
  {{- with .node.resources }}
    resources: {{- toYaml . | nindent 10 }}
  {{- end }}
{{- if $.Values.videoRecorder.enabled }}
  - name: "pre-puller-{{ $.Values.videoRecorder.name }}"

would already be suficient do do this.

Command used to start Selenium Grid with Docker (or Kubernetes)

helm install

Relevant log output

36s         Warning   FailedCreate        replicaset/selenium4-selenium-edge-node-688b799797      Error creating: admission webhook "validation.gatekeeper.sh" denied the request: [container-must-have-limits] container <pre-puller-selenium4-selenium-edge-node> has no resource limits

Operating System

Kubernetes

Docker Selenium version (image tag)

4.24.0-20240907

Selenium Grid chart version (chart version)

0.35.2

[github-actions]

@Koeppchen, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[VietND96]

We will also consider to add the admission webhook "validation.gatekeeper.sh" https://github.com/open-policy-agent/gatekeeper to the test cluster to detect such issue early.

[Koeppchen]

Thank you,
it might be hard to define gatekeeper configuration for those test cases. But of course resource limits is a very common one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.