[🐛 Bug]: Regression: imageName variable not working properly in Helm chart v0.25.1+

[durera]

What happened?

In 0.25.0 setting e.g. the following in a values file and running helm install -n selenium selenium-grid docker-selenium/selenium-grid -f /tmp/selenium-values.yml:

edgeNode:
  imageName: mylocalregistry/selenium/node-edge
  imageTag: 4.15.0-20231122
  imagePullSecret: mypullsecret

results in the expected image being used in the deployment:

      image: mylocalregistry/selenium/node-chrome:4.15.0-20231122

As of 0.25.1 it results in the following - with the namespace prefixed to the image name:

      image: selenium/mylocalregistry/selenium/node-chrome:4.15.0-20231122

Command used to start Selenium Grid with Docker

helm install -n selenium selenium-grid docker-selenium/selenium-grid -f /tmp/selenium-values.yml

Relevant log output

helm list
NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION    
selenium-grid   selenium        1               2023-11-29 15:55:13.804552928 +0000 UTC deployed        selenium-grid-0.25.3    4.15.0-20231129

Operating System

Kubernetes

Docker Selenium version (tag)

selenium-grid-0.25.3 / 4.15.0-20231129

[github-actions]

@durera, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[diemol]

0.25.3 is out and I believe that is fixed.

[durera]

0.25.3 is out and I believe that is fixed.

Afraid not ... hit the same in 0.25.1 and 0.25.3 (reproduced on 0.25.3 just now, as below):

helm -n selenium list
NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION    
selenium-grid   selenium        1               2023-11-29 17:40:37.1863814 +0000 UTC   deployed        selenium-grid-0.25.3    4.15.0-20231129

Same result (snippet from selenium-chrome-node-xxx deployment, from a 0.25.3):

      envFrom:
        - configMapRef:
            name: selenium-event-bus-config
        - configMapRef:
            name: selenium-node-config
      image: >-
        selenium/XXXX/selenium/node-chrome:4.15.0-20231122
  serviceAccount: selenium-serviceaccount
  volumes:
    - name: dshm
      emptyDir:
        medium: Memory
        sizeLimit: 1Gi
    - name: kube-api-access-47vz4

[VietND96]

Hello @durera
I assume the image in your local repo would be mylocalregistry/selenium/node-edge:4.15.0-20231122
Can you please try this config with latest chart 0.25.3

edgeNode:
  imageRegistry: mylocalregistry/selenium
  imageName: node-edge
  imageTag: 4.15.0-20231122
  imagePullSecret: mypullsecret

[durera]

Hello @durera I assume the image in your local repo would be mylocalregistry/selenium/node-edge:4.15.0-20231122 Can you please try this config with latest chart 0.25.3

edgeNode:
  imageRegistry: mylocalregistry/selenium
  imageName: node-edge
  imageTag: 4.15.0-20231122
  imagePullSecret: mypullsecret

Yeah, that's correct ... I'll give it a try with imageRegistry when we update, I see the updated doc is in https://github.com/SeleniumHQ/docker-selenium/blob/trunk/charts/selenium-grid/README.md now with the details of the new param, thanks 👍

[VietND96]

Thank you for your confirmation. I also added a test to guarantee regression.