fix: Formatter adding extra parentheses around operator chaining expressions inside function calls and arrays #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #305
I changed the way
_format_operator_chain_based_expression_to_multiple_lines
wraps long expressions in parentheses.To achieve this, I pass around
is_inside_list
in theExpressionContext
way back from the_format_comma_separated_list_to_multiple_lines
. Unfortunately, that means that_format_contextless_comma_separated_list_to_multiple_lines
and_format_contextless_operator_chain_based_expression_to_multiple_lines
are now not truly contextless.