Remove cftime.utime #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all deprecated calls of
cftime.utimeand uses the "new" way.Made some pep8 fixes because the
pep8cli was asking for them.There are
21 errorsleft. They are unrelated to this PR, but seem to come from changes incftimetoo. I will dig a bit more.EDIT: Fixed the error relating to 360_day calendar. Many calls to
cftime.datetimewere missing the calendar, I added it as this was the issue at least for that error. Also followed to instruction of aDeprecationWarningand changednp.objecttoobject.