Skip to content

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Sep 17, 2025

🚀 Pull Request

Description

Addresses first of two parts of #6473 i.e., supporting masked aux coords for Cube.aggregated_by.

Follow-on separate pull-request will address supporting masked aux coords for Cube.collapsed.

  • Add unit test coverage

Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bjlittle bjlittle marked this pull request as draft September 17, 2025 12:52
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (57a316c) to head (7d5caea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6706   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files          91       91           
  Lines       24467    24472    +5     
  Branches     4568     4569    +1     
=======================================
+ Hits        22092    22097    +5     
  Misses       1607     1607           
  Partials      768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjlittle bjlittle removed this from 🚴 Peloton Sep 19, 2025
@bjlittle bjlittle moved this to 👀 In Review in 🦌 Iris 3.14 Sep 19, 2025
@bjlittle bjlittle marked this pull request as ready for review September 19, 2025 14:21
@bjlittle bjlittle linked an issue Sep 19, 2025 that may be closed by this pull request
@bjlittle bjlittle requested a review from ESadek-MO September 19, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Aggregating a masked auxiliary coordinate removes mask
2 participants