NF - add 1D scatter plot functions. #617
Conversation
lib/iris/tests/test_plot.py
Outdated
There was a problem hiding this comment.
Did you intend this to have the c=c argument?
There was a problem hiding this comment.
Hmm, yes I think I did. Not that it matters much though. I'll sort it out.
There was a problem hiding this comment.
Agreed - it doesn't matter much at all but it gives the previous line a reason to exist.
FWIW I wasn't doing a full review, I just happened to spot it when I was looking for some code which used the new function because I was pondering the overlap between iplt.points and iplt.scatter.
|
Neat 😀 |
|
The omission of the |
|
It looks like it'd make sense for the quickplot version to add a colorbar, as for contourf and pcolor[mesh]? |
I guess it might do, I hadn't thought of that. It would only make sense to do this when the |
Good point. I'd be happy to leave this for another time - perhaps adding cube/coord support to the |
|
Allowing Anyway, if you are happy for colorbars to be left out then I'm happy to leave them out of this PR. |
👍 |
|
Please could you rebase 7f789386a7bc19a158a93fc721fa253590f7709d onto the latest master (which includes #634) so the Travis tests can run. |
|
Rebased and tests passing. |
|
Lovely. Thanks @ajdawson 😄 |
NF - add 1D scatter plot functions.
2 participants
Adds 1D scatter plot functionality to
iris.plotandiris.quickplot, capitalising on the new 1D plotting features added in #593.Some of the test plots are not too pretty, but they should serve well enough!