Refactor warnings from iris.exceptions into iris.warnings
#5760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5760 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.03%
==========================================
Files 90 92 +2
Lines 22815 22940 +125
Branches 5438 5462 +24
==========================================
+ Hits 20468 20588 +120
- Misses 1617 1620 +3
- Partials 730 732 +2 ☔ View full report in Codecov by Sentry. |
trexfeathers
changed the title
iris.exceptions into iris.warnings.iris.exceptions into iris.warnings
HGWright
approved these changes
Feb 20, 2024
Contributor
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
Great job, glad we caught this before the release!
Contributor
Author
|
Thanks @HGWright! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 21, 2024
* upstream/main: Refactor warnings from `iris.exceptions` into `iris.warnings` (SciTools#5760)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Following @bjlittle's suggestion here: #5506 (comment)
Consult Iris pull request check list