Refactor area weighted regridding, improve performance #5543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
stephenworsley
added
the
benchmark_this
Performance Benchmark Report: 86aa0d1Performance shiftsFull benchmark resultsGenerated by GHA run |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
==========================================
+ Coverage 89.41% 89.55% +0.13%
==========================================
Files 89 89
Lines 22539 22495 -44
Branches 5387 5351 -36
==========================================
- Hits 20154 20146 -8
+ Misses 1639 1616 -23
+ Partials 746 733 -13 ☔ View full report in Codecov by Sentry. |
|
Note: this PR builds a wights matrix and performs regridding with the expectation that the standard cube has the last two dimensions as the y and x dimension (see the change made in this commit 90130cc). This decision is made in order to maintain consistency with patterns established in existing regridders, e.g. the ordering of iris/lib/iris/analysis/_regrid.py Line 365 in e0850eb This cosistency is important so that further unification of regridding can take place without having to change the expected ordering of weights matrices associated with regridders. This decision is also in keeping with recomendations in CF conventions, see http://cfconventions.org/Data/cf-conventions/cf-conventions-1.10/cf-conventions.html#dimensions |
HGWright
requested changes
Nov 20, 2023
HGWright
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Great work @stephenworsley, merging this and we will add a whatsnew entry in a seperate PR
Merged
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 27, 2023
* upstream/main: Mergeback of `FEATURE_chunk_control` branch (SciTools#5588) [CI Bot] environment lockfiles auto-update (SciTools#5547) Mergeback of "Feature _split_attrs" branch (SciTools#5152) add whatsnew (SciTools#5596) Refactor area weighted regridding, improve performance (SciTools#5543) Allowing exemption to axis guessing on coords (SciTools#5551)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 6, 2023
* main: DOCS: Numpydocs1 (SciTools#5578) add links to scitools-classroom repo. (SciTools#5609) Feedstock rc branch management in do-nothing script (SciTools#5515) Relocated the Technical Papers documentation to Further Topics. (SciTools#5602) Fix pp save of realization coordinate (SciTools#5568) Bump actions/checkout from 3 to 4 (SciTools#5460) Bump actions/github-script from 6 to 7 (SciTools#5580) Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607) CI: specify matplotlib-base (SciTools#5606) Mergeback of `FEATURE_chunk_control` branch (SciTools#5588) [CI Bot] environment lockfiles auto-update (SciTools#5547) Mergeback of "Feature _split_attrs" branch (SciTools#5152) add whatsnew (SciTools#5596) Refactor area weighted regridding, improve performance (SciTools#5543) Allowing exemption to axis guessing on coords (SciTools#5551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Implements #5365.