Splitattrs cube metadata #5038
Closed
Splitattrs cube metadata #5038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
splitattrs_cube_metadata
branch
from
eb9b213 to
254b7a6
Compare
pp-mo
force-pushed
the
splitattrs_cube_metadata
branch
from
254b7a6 to
a254d39
Compare
pp-mo
force-pushed
the
splitattrs_cube_metadata
branch
from
516ef87 to
6cc4630
Compare
|
Closing in favour of #5040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4982
This implements the basics of adding a separate
.global_attributesfield to aCubeMetadata,and tests that it behaves exactly the same as the
.attributesfield.NB this field is not yet accessible from the cube itself, so no behaviour changes should result.
That awaits #4983, which will replace the implemenation of
cube.attributesand addcube.attributes.localandcube.attributes.global.