Skip to content

Correct wrong type of equality check in benchmark GHA. #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

Correct wrong type of equality check in benchmark GHA. #5005

merged 1 commit into from
Sep 29, 2022

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Sep 29, 2022 •
edited
Loading

😳

In #5001 I intended to generate first_commit ONLY IF it was not already provided by the workflow_dispatch, but I got my equality the wrong way round.

@trexfeathers trexfeathers mentioned this pull request Sep 29, 2022
Merged
stephenworsley
stephenworsley approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yeah, this one makes more sense in retrospect.

@stephenworsley stephenworsley merged commit 24ff3bd into SciTools:main Sep 29, 2022
@trexfeathers
Copy link
Contributor Author

Life-saver, thanks again @stephenworsley!

@trexfeathers trexfeathers deleted the bm_fixes_2 branch October 12, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

Assignees

No one assigned

Labels

Type: Performance Type: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trexfeathers @stephenworsley