Skip to content

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

These changes address a Matplotlib deprecation warning, and should get the overnight benchmarks working again.


Consult Iris pull request check list

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool, though I did have a bit of a wobble about requiring Matplotlib >= 3.5.
That is now ~10months old. But I guess this is anyway not an actual Iris dependency, its only for CI,
so I think that is fine.

@pp-mo pp-mo merged commit 04e757f into SciTools:main Sep 28, 2022
@pp-mo
Copy link
Member

pp-mo commented Sep 28, 2022

Nice work @trexfeathers . We'll see how it goes tomorrow morning !

@trexfeathers
Copy link
Contributor Author

This looks cool, though I did have a bit of a wobble about requiring Matplotlib >= 3.5. That is now ~10months old. But I guess this is anyway not an actual Iris dependency, its only for CI, so I think that is fine.

This is genuine. When this is released (December), Matplotlib 3.4 will not be usable with Iris

@pp-mo
Copy link
Member

pp-mo commented Sep 28, 2022

Ok, hadn't really thought of it that way.
But by then, mpl 3.5 will be > 1 year old.

@trexfeathers
Copy link
Contributor Author

This raises interesting questions about proactively responding to deprecation warnings. We typically don't spot them until the deprecation fully happens, and therefore don't experience the problem of very 'young' pins. In this case I spotted the warning while investigating and chose to action it, introducing this different problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants