Skip to content

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jan 11, 2022

🚀 Pull Request

Description

This PR manually updates the py38-linux-64.lock based on the contents of GHA PR #4480 (which I've now closed)

This PR includes the recent changes (#4486) to address supporting the latest numpy 1.22.0 release.

There are failures to investigate here, due to the dependency updates... so this PR is a work-in-progress, but also mainly for transparency given the current iris 3.2.0 release efforts.

Failures to address:

  • iris.tests.integration.test_trajectory
    • TestTriPolar.test_tri_polar
    • TestLazyData.test_hybrid_height
  • iris.tests.unit.analysis.cartography.test_rotate_grid_vectors.TestRotateGridVectors
    • test_angles_calculation
    • test_angles_in_radians
    • test_nan_vectors
  • iris.tests.integration.plot.test_vector_plots.TestBarbs
    • test_2d_plain_latlon
    • test_2d_rotated_latlon
    • test_2d_plain_latlon_on_polar_map

Reference GHA PR #4507 (closed)


Consult Iris pull request check list

@bjlittle bjlittle marked this pull request as draft January 11, 2022 12:24
@bjlittle bjlittle self-assigned this Jan 12, 2022
@bjlittle bjlittle force-pushed the update-ci-py38-lock branch 2 times, most recently from 172db57 to 73c9040 Compare January 18, 2022 14:58
@bjlittle bjlittle force-pushed the update-ci-py38-lock branch from 1a0147f to b4b4ec2 Compare January 19, 2022 21:46
@bjlittle bjlittle changed the title wip: manual update to py38-linux-64.lock (#4480) manual update to py38-linux-64.lock (#4480) Jan 19, 2022
@bjlittle bjlittle marked this pull request as ready for review January 19, 2022 22:11
@bjlittle bjlittle removed their assignment Jan 19, 2022
@bjlittle
Copy link
Member Author

bjlittle commented Jan 20, 2022

Additionally, we could choose to additionally pass the rounding=False kwarg to the following three barbs tests:

  • iris.tests.integration.plot.test_vector_plots.TestBarbs
    • test_2d_plain_latlon
    • test_2d_rotated_latlon
    • test_2d_plain_latlon_on_polar_map

This will counter the disparity in behaviour between Intel SVML supported and unsupported CPUs, but this would also mean updating the associated imagerepo.json entries and adding additional images to the test-iris-imagehash repo.

I'm not fussed either way, but it would have the advantage that a user with a local host with SVML support being able to run tests that pass independent of disabling the numpy AVX512 support (and using nox)... 😐

@bjlittle bjlittle force-pushed the update-ci-py38-lock branch from e7af85b to f9427b6 Compare January 20, 2022 09:30
@jamesp jamesp self-requested a review January 20, 2022 10:38
@jamesp jamesp merged commit e3df0a0 into SciTools:main Jan 20, 2022
@bjlittle
Copy link
Member Author

Awesome, thanks @jamesp 🍻

@bjlittle bjlittle deleted the update-ci-py38-lock branch January 21, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants