Skip to content

Add a method to return a CubeList from CubeList.copy() #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2021
Merged

Add a method to return a CubeList from CubeList.copy() #4094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2465c35
Add a method to return a CubeList from CubeList.copy()
Badboy-16 Apr 9, 2021
12359f0
Created an entry in What's New
Badboy-16 May 27, 2021
762ef99
Added test for CubeList.copy()
Badboy-16 May 27, 2021
eb17561
Moved CubeList.copy() test into the correct file
Badboy-16 May 27, 2021
8b54230
Creating a link to the username
Badboy-16 May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ This document explains the changes made to Iris for this release
printing these objects skips metadata elements that are set to None or an
empty string or dictionary. (:pull:`4040`)

#. `@Badboy-16`_ implemented a ``CubeList.copy()`` method to return a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link also needs creating toward the bottom of the file - currently L172-174.

That will fix the test failures.

``CubeList`` object instead of a ``list``. (:pull:`4094`)


🐛 Bugs Fixed
=============
Expand Down Expand Up @@ -170,6 +173,7 @@ This document explains the changes made to Iris for this release
core dev names are automatically included by the common_links.inc:

.. _@akuhnregnier: https://github.com/akuhnregnier
.. _@Badboy-16: https://github.com/Badboy-16
.. _@gcaria: https://github.com/gcaria
.. _@MHBalsmeier: https://github.com/MHBalsmeier

Expand All @@ -189,4 +193,4 @@ This document explains the changes made to Iris for this release
.. _Python 3.8: https://www.python.org/downloads/release/python-380/
.. _README.md: https://github.com/SciTools/iris#-----
.. _xxhash: http://cyan4973.github.io/xxHash/
.. _conda-lock: https://github.com/conda-incubator/conda-lock
.. _conda-lock: https://github.com/conda-incubator/conda-lock
7 changes: 7 additions & 0 deletions lib/iris/cube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,13 @@ def realise_data(self):
"""
_lazy.co_realise_cubes(*self)

def copy(self):
"""
Return a CubeList when CubeList.copy() is called.
"""
if type(self) == CubeList:
return deepcopy(self)


def _is_single_item(testee):
"""
Expand Down
9 changes: 9 additions & 0 deletions lib/iris/tests/unit/cube/test_CubeList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,5 +602,14 @@ def test_realise_data(self):
)


class Test_CubeList_copy(tests.IrisTest):
def setUp(self):
self.cube_list = iris.cube.CubeList()
self.copied_cube_list = self.cube_list.copy()

def test_copy(self):
self.assertIsInstance(self.copied_cube_list, iris.cube.CubeList)


if __name__ == "__main__":
tests.main()