Skip to content

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

For original review, see SciTools-incubator/iris-ugrid#38.

I'm keen in future to extend this beyond UGRID-NetCDF files, as the pattern is very useful for good benchmark coverage.


Consult Iris pull request check list

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing to the content in ris-ugrid, I see you subtly refactored the scope of this with a view to future generalisation, e.g. beyond netcdf. Which I think is all good, and nicely done!

I thought of some tiny tweaks, but otherwise looks fine.

@pp-mo pp-mo merged commit 8c08d14 into SciTools:mesh-data-model Mar 26, 2021
@trexfeathers trexfeathers deleted the stock_netcdf branch March 26, 2021 15:06
@trexfeathers
Copy link
Contributor Author

Thanks @pp-mo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants