Deprecate iris.util.as_compatible_shape #3892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
approved these changes
Sep 30, 2020
So it's apparently not appropriate to remove such references until the feature is actually removed, once it has been deprecated for long enough. There will be no need to raise an issue since final removal will cause test failures so they can't be missed. |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Oct 8, 2020
* upstream/master: add SciTools#3791 whatsnew entry (SciTools#3897) bump whatsnew latest and version to 3.1.dev0 (SciTools#3896) hide the further topics toc (SciTools#3894) Deprecate iris.util.as_compatible_shape (SciTools#3892) whatsnew additions (SciTools#3891) linkcheck ignore http://cfconventions.org (SciTools#3889) Cube arithmetic docs to master (SciTools#3890) added whats new for pr SciTools#3884 (SciTools#3887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
The PR marks the
iris.util.as_compatible_shapefunction for deprecation fromirisin a future release, in preference for using an instance of theiris.common.resolve.Resolveclass.Consult Iris pull request check list