Skip to content

Conversation

@stephenworsley
Copy link
Contributor

Addresses #3807.

@stephenworsley stephenworsley marked this pull request as draft September 3, 2020 14:55
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephenworsley! I'm satisfied that between us we have covered everything that happened in #3762. I've left a single comment for you to address 🙂

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be good to be able to reference the changes, at least where they can be identified. Thoughts?

Add reference to source of changes

Co-authored-by: Martin Yeo <[email protected]>
@trexfeathers trexfeathers marked this pull request as ready for review September 4, 2020 13:19
Copy link
Contributor Author

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm satisfied with the additions @trexfeathers has provided.

@trexfeathers trexfeathers merged commit 2c5cdfb into SciTools:master Sep 4, 2020
tkknight added a commit to tkknight/iris that referenced this pull request Sep 7, 2020
…haul

* upstream/master:
  move whatsnew contributions (SciTools#3816)
  Parse with packaging version (SciTools#3815)
  Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811)
  tidy issue templates (SciTools#3814)
  Legacy doc notice (SciTools#3813)
  Update issue templates
  Update issue templates
  Update issue templates
  Unpin Matplotlib and proj (SciTools#3762)
tkknight added a commit to tkknight/iris that referenced this pull request Sep 8, 2020
* master:
  Add template collapsible markdown section (SciTools#3823)
  Requirements re-haul (SciTools#3812)
  Automate pull request labels (SciTools#3819)
  move whatsnew contributions (SciTools#3816)
  Parse with packaging version (SciTools#3815)
  Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811)
  tidy issue templates (SciTools#3814)
  Legacy doc notice (SciTools#3813)
tkknight added a commit to tkknight/iris that referenced this pull request Sep 11, 2020
* master: (36 commits)
  Rework whatsnew into new scheme. (SciTools#3834)
  Lazy regridding with Linear, Nearest, and AreaWeighted (SciTools#3701)
  Iris readme minimal (SciTools#3833)
  Fix sphinx logger (SciTools#3832)
  whatsnew entry for dependencies (SciTools#3831)
  Added link to scitools.org.uk on the main index. (SciTools#3830)
  Updated Iris install instructions (SciTools#3817)
  Delete labeler.yml
  Delete label.yml
  Create label.yml
  Delete labeler.yml
  Update labeler.yml
  Update labeler.yml
  Add template collapsible markdown section (SciTools#3823)
  Requirements re-haul (SciTools#3812)
  Automate pull request labels (SciTools#3819)
  move whatsnew contributions (SciTools#3816)
  Parse with packaging version (SciTools#3815)
  Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811)
  tidy issue templates (SciTools#3814)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants