Clarify unit handling #3803
Merged
Clarify unit handling #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair-gemmell
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Looks good @stephenworsley ! This clearly worded description will really help users understand the change.
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Aug 29, 2020
* master: Support for climatological in Coord.from_coord() and DimCoord.from_regular(). (SciTools#3802) clarify unit handling (SciTools#3803) Add quality flags to whatsnew (SciTools#3801) add args/kwargs to DimCoord.__init__ docstring (SciTools#3681) Merge launch_ancils feature branch. Modify parsing of ff headers to avoid numpy.fromfile. (SciTools#3791)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we have clarified our position on units, as detailed in #3708, our interpretation of units should be made clear somewhere in the documentation. I have done this as part of a discussion on the functional effect units have on arithmetic within the user guide, which was also missing and is probably also worth documenting.