pin cftime #3750
Merged
pin cftime #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Happy that the tests are passing again, and that we've raised #3751 to address properly. Let's not let it be forgotten, freedom from pins is very liberating! |
trexfeathers
approved these changes
Jul 6, 2020
|
Nice one, thanks @trexfeathers. Not only have I raised the issue, but I've made sure to add the |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 6, 2020
* master: pin cftime (SciTools#3750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily pins back
cftime, which is causing some unit test failures due to its most recent release, moving fromv1.1.3tov1.2.0, see the Unidata/cftime changelog.The following
iris.tests.unit.fileformats.pp_load_rules.test__epoch_date_hours.TestEpochHours__gregorianunit tests fail, all of which deal with our workaround for handling dates with a year of0(pretty much), and all of which are now 48hrs out usingv1.2.0ofcftime😕:test_year_0test_ymd_0_0_0test_ymd_preserves_timeofdaytest_ymd_1_1_1