-
Couldn't load subscription status.
- Fork 297
Ucube utils #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ucube utils #3692
Conversation
|
I don't understand why no tests are running. Tests are still running on my fork : https://travis-ci.org/github/pp-mo/iris/builds/669350910 Tests are also not running in test-iris-imagehash, either ... |
|
I think they are running (see here for the results of the travis run for this PR), but for some reason travis isn't sending the results back to github? |
Thanks @lbdreyer |
|
Update: the testing problem is not a "glitch". |
Tiny docstring tweaks.
|
Created PR with small changes to this, in own repo (since merged, so appears here) : pp-mo#60 In this, on own fork, same thing of the PR not linking to the Travis tests. |
Something has changed, I'm struggling to t know how to chase this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @pp-mo I haven't quite finished looking at this. But I do know that you'll need to update the test data ref in travis.yml to the latest commit from iris-test-data PR 57. Catch you next week!
I just re-ran the Travis tests and now I've got that information back on this PR. In order to re-run the tests I had to log out of Travis and log back in since the restart button wasn't there the first time. I don't know whether it was the log-in or the re-run that has fixed it for me. |
Thanks for persevering -- this is great news! |
|
In theory, if I now just install the latest iris-test-data SHA in .travis.yml, this will then pass ... |
|
This all looks great, thanks @pp-mo! |
Tidied and pulled in the code that I wrote for the recent demo, mainly supporting the mesh subset operations based on gridded/UGRID.
I included everything from there, and added at least one simple test for each function.
This needs a new image test-iris-imagehash and a new testfile in iris-test-data,
so it won't pass tests until both of these PRs are in :
WIP
still todo: fix iris-test-data SHA in Travis, when SciTools/iris-test-data#57 is done.