Skip to content

Remove TestGribMessage (ported to iris-grib) #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Remove TestGribMessage (ported to iris-grib) #3672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 0 additions & 110 deletions lib/iris/tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,116 +1121,6 @@ class GraphicsTest_nometa(GraphicsTestMixin, IrisTest_nometa):
pass


class TestGribMessage(IrisTest):
def assertGribMessageContents(self, filename, contents):
"""
Evaluate whether all messages in a GRIB2 file contain the provided
contents.

* filename (string)
The path on disk of an existing GRIB file

* contents
An iterable of GRIB message keys and expected values.

"""
messages = GribMessage.messages_from_filename(filename)
for message in messages:
for element in contents:
section, key, val = element
self.assertEqual(message.sections[section][key], val)

def assertGribMessageDifference(
self, filename1, filename2, diffs, skip_keys=(), skip_sections=()
):
"""
Evaluate that the two messages only differ in the ways specified.

* filename[0|1] (string)
The path on disk of existing GRIB files

* diffs
An dictionary of GRIB message keys and expected diff values:
{key: (m1val, m2val),...} .

* skip_keys
An iterable of key names to ignore during comparison.

* skip_sections
An iterable of section numbers to ignore during comparison.

"""
messages1 = list(GribMessage.messages_from_filename(filename1))
messages2 = list(GribMessage.messages_from_filename(filename2))
self.assertEqual(len(messages1), len(messages2))
for m1, m2 in zip(messages1, messages2):
m1_sect = set(m1.sections.keys())
m2_sect = set(m2.sections.keys())

for missing_section in m1_sect ^ m2_sect:
what = (
"introduced" if missing_section in m1_sect else "removed"
)
# Assert that an introduced section is in the diffs.
self.assertIn(
missing_section,
skip_sections,
msg="Section {} {}".format(missing_section, what),
)

for section in m1_sect & m2_sect:
# For each section, check that the differences are
# known diffs.
m1_keys = set(m1.sections[section]._keys)
m2_keys = set(m2.sections[section]._keys)

difference = m1_keys ^ m2_keys
unexpected_differences = difference - set(skip_keys)
if unexpected_differences:
self.fail(
"There were keys in section {} which \n"
"weren't in both messages and which weren't "
"skipped.\n{}"
"".format(section, ", ".join(unexpected_differences))
)

keys_to_compare = m1_keys & m2_keys - set(skip_keys)

for key in keys_to_compare:
m1_value = m1.sections[section][key]
m2_value = m2.sections[section][key]
msg = "{} {} != {}"
if key not in diffs:
# We have a key which we expect to be the same for
# both messages.
if isinstance(m1_value, np.ndarray):
# A large tolerance appears to be required for
# gribapi 1.12, but not for 1.14.
self.assertArrayAlmostEqual(
m1_value, m2_value, decimal=2
)
else:
self.assertEqual(
m1_value,
m2_value,
msg=msg.format(key, m1_value, m2_value),
)
else:
# We have a key which we expect to be different
# for each message.
self.assertEqual(
m1_value,
diffs[key][0],
msg=msg.format(key, m1_value, diffs[key][0]),
)

self.assertEqual(
m2_value,
diffs[key][1],
msg=msg.format(key, m2_value, diffs[key][1]),
)


def skip_data(fn):
"""
Decorator to choose whether to run tests, based on the availability of
Expand Down