Skip to content

Conversation

@stephenworsley
Copy link
Contributor

A derived coordinate can now be removed by calling Cube.remove_coord(). Fixes #3637. aggregated_by() now handles derived coordinates. The behaviour of aggregated_by is now that derived coordinates will become regular coordinates if they span the dimension aggregated along.

@stephenworsley stephenworsley added this to the v3.0.0 milestone Jun 9, 2020
@stephenworsley stephenworsley changed the title Allow derived coordinates to be removed PI-3637: Allow derived coordinates to be removed Jun 9, 2020
@pp-mo pp-mo merged commit 3398e87 into SciTools:master Jun 15, 2020
@pp-mo
Copy link
Member

pp-mo commented Jun 15, 2020

Thanks @stephenworsley .

Unfortunately I think merge was a bit premature : I just realised that it still needs a whatsnew.
Can you maybe address that ?

The effective change to 'aggregated_by' also needs a bit more attention, I think.
As a minimum, I'd suggest a separate whatsnew for that.
However, I'm also still very doubtful whether the 'new' behaviour of 'aggregated_by' is a correct resolution : If we have aggregated all the dependency coordinates, can we not construct a proper derived coord for the result in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cube.aggregated_by() fails when derived coordinates are present

3 participants