PI-3483 (if not merging 3478) Safe arithmetic #3618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
reviewed
Dec 20, 2019
stickler-ci
reviewed
Dec 20, 2019
6 tasks
stephenworsley
changed the title
stephenworsley
changed the title
bjlittle
requested changes
Dec 20, 2019
There was a problem hiding this comment.
@stephenworsley @pp-mo @abooton Tagging iris 3.0.0 without #3478 would be a major mistake.
I'm completely 👎 on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align arithmetic with previous behaviour wrt CellMeasure
In the absence of changes to arithmetic due with #3478, cube arithmetic is given the "safe" behaviour of always discarding cell measures and ancillary variables. This aligns with the previous behaviour of arithmetic discarding cell measures (which was previously due to copy discarding cell measures). This solves one of the remaining issues in #3483 and allows loading of ancillary variables to be merged in safely if the canges made to cube arithmetic don't make it into 3.0.