-
Notifications
You must be signed in to change notification settings - Fork 297
Fix bug with html_repr #3373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with html_repr #3373
Conversation
Alternatively, my new commit adds the new line to the previous cell instead of a new row.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenworsley thanks for getting a fix in place for this annoying bug with the cube html repr! Could I ask you to add a test for this new functionality to Test__make_content please, as well as a new test class in the same test module for the new method you've added? Doesn't have to be anything special, just enough to check it's doing what we want (as well as nothing we don't!). Thanks!
Long enough, I think it's good! |
Fixes the bug with #3351.
Previously, if a cube had an attribute which was a string containing '\n', attempting to get the html_repr of that cube would cause an exception. This pull request would instead add what is in that new line to a new row of the html_repr.
A cube whose string representation looks like:
will now have a html_repr which creates a table looking something like:
This cube and its representations were created with the following code using attributes taken from #3351: