-
Notifications
You must be signed in to change notification settings - Fork 297
Adds lazy version of aggregated_by routine to Cube. #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I haven't had time to check code in depth yet, Some tests for the new functionality will be wanted. P.S. We just fixed the CI header tests, so sorry about that ! |
|
Thanks! Yes, I am going through the checklist now and will add tests and whatsnew and whatnot :). In fact, this is the only reason why this is marked as WIP, the code itself is considered finished and of course works for me. Maybe to ease reading it: I completely kept the code for the non-lazy version, just put it in the else branch of an if statement guarding the lazy version in the exact same way as in the collapsed method. A more aggressive version is possible were also the non-lazy part is implemented in the same way as the lazy part with only |
Closes SciTools#3280 Signed-off-by: Klaus Zimmermann <[email protected]>
58d5c30 to
529e980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @zklaus ! This is a really nice, clean addition!
I just have a comment on the testing of 2D coordinates
|
@zklaus great ! |
Closes #3280
Signed-off-by: Klaus Zimmermann [email protected]