Skip to content

Conversation

@meganfitzsimons
Copy link
Contributor

Colourised the two iris logos

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Apr 24, 2018
@stickler-ci

This comment has been minimized.

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label May 1, 2018
@pelson
Copy link
Member

pelson commented May 1, 2018

Thanks for your first contribution @meganfitzsimons! 🎉

I've added both yourself and @niallrobinson to the contributors list so the CLA checker should start going green shortly. (The travis tests are a separate issue, which we have resolved on master - nothing for you to do on that from).

I've marked this for "decision needed", simply because this is a subjective appearance change, and we really need to get some form of consensus about the design. Beyond just the logo, have you by any chance taken a look at the iris docs that might help the development team buy-in to the proposed changes?

Essentially, I think we should probably have a broad vote using the reaction buttons (:+1: / :-1:) to the original PR description. For those who would like to vote, but who aren't yet decided, please vote with a :confused: - no guarantee that if there is clear consensus we will wait for all :confused: to become votes, but at least it gives an indication of who wants to be involved with the conversation.

I'll start by placing my 😕 vote, as I'd love to see a bigger picture before moving forwards with specific logo changes.

Thanks again @meganfitzsimons - and please don't take offence at my 😕, it is the only symbol we have that represents neither a a resounding yes or a resounding no! 😄

@niallrobinson
Copy link
Contributor

@pelson

bigger picture

Do you mean more pixels or in context? The pixels are the same what was there before.

@pelson
Copy link
Member

pelson commented May 2, 2018

Do you mean more pixels or in context? The pixels are the same what was there before.

Touché.

In this instance, I mean where does this lead. My perspective is that colorising the logo is just the first of many things that need to be addressed in order to give iris a sense of modernity.

I guess the point is, by itself, adding colour to the logo doesn't do that, therefore I'd personally need to have a sense of direction before we take the first step...

@pelson pelson mentioned this pull request May 5, 2018
@niallrobinson
Copy link
Contributor

therefore I'd personally need to have a sense of direction before we take the first step...

@meganfitzsimons doesn't have time to do a full rebrand unfortunately. Can I invoke the "that is divisible and should be a separate PR" clause? We could view this as a fundamental change in iris branding - or we could just treat it as the same logo but with the implied colours on.

@niallrobinson
Copy link
Contributor

niallrobinson commented Jul 20, 2018

hi avd - are we really going to block simply colouring in a logo because we'd rather someone did a full rebrand?
image
good news - people like Iris, bad news the logo looks atrocious next to the others. @meganfitzsimons

@jacobtomlinson
Copy link

jacobtomlinson commented Jul 20, 2018

Given that @pelson suggested a vote two months ago and we are currently at five 👍, two 😕 and zero 👎 I think the winner is to merge this.

I agree with @niallrobinson that this is a minor (but very useful) enhancement to the existing branding, but we should also raise an issue to discuss a rebrand.

@pelson
Copy link
Member

pelson commented Jul 25, 2018

bad news the logo looks atrocious next to the others

This is incredibly subjective - please try to use language that reflects that. Also, please be respectful that Iris is not just a Met Office thing. People don't know what "avd" actually is, and excluding others who may want to be involved in the conversation is never a healthy thing.

I've already stated my position. I frankly do not see a benefit to a logo change alone. I'm fine with iterating, but not iterating in a random direction.

Given that the implication of the change is a chain reaction of pull requests and a non-zero amount of effort after merging this PR, I won't be merging this in the current state of discussion.

Finally, please be aware that 2 of the 3 SciTools steering council members have raised 😕. This should be a clear indication that there isn't broad consensus, and that yes, there is more work to be done before this should be merged. That doesn't mean that "we" are "really going to block simply colouring in a logo because we'd rather someone did a full rebrand", but it does mean that some more effort is required to layout an agreed sense of direction before we start traveling.

@niallrobinson
Copy link
Contributor

niallrobinson commented Jul 25, 2018

also, please be respectful that Iris is not just a Met Office thing

That's a fair point - sorry non-Met Office people.

chain reaction of pull requests and a non-zero amount of effort after merging this PR, I won't be merging this in the current state of discussion. Finally, please be aware that 2 of the 3 SciTools steering council members have raised 😕.

Also fair enough, in which case I'll close this PR and we can always pick up the contribution if the broader discussion happens.

Edit: looks like I can't close it actually

@jacobtomlinson
Copy link

I fully sympathise with your comments but still encourage you all to consider this change. As someone who spends a reasonable amount of time advocating iris I feel this would be very helpful to me.

Out of curiosity what makes you say:

Given that the implication of the change is a chain reaction of pull requests and a non-zero amount of effort after merging this PR, I won't be merging this in the current state of discussion.

I'm not sure I follow the logic?

@niallrobinson
Copy link
Contributor

I guess it triggers a bunch of website/document building, deploying and checking.

@pelson
Copy link
Member

pelson commented Jul 25, 2018

Also fair enough, in which case I'll close this PR and we can always pick up the contribution if the broader discussion happens.

That is OK, but to be clear, it isn't really the desired outcome for anybody. We do all want to see Iris improve its branding, and especially to improve the quality of its documentation, where layout and design have a big part to play.

Don't know how much space you have to co-locate and thrash out some html / design concepts, but I'd be up for that - we'd still need to come back to GitHub to make the final agreement, but would certainly speed up the iteration.

Closing on your behalf, but please don't see this as a closed book.

@pelson pelson closed this Jul 25, 2018
@niallrobinson
Copy link
Contributor

Don't worry - I disagree about the value of the change (obviously - as per the discussion), but I completely understand not having the bandwidth to take it forward. Unfortunately we are in a similar position - we just thought that this would be a quick easy low-hanging-fruit win that we could contribute on the side.

@bjlittle
Copy link
Member

Re-opening this...

I'm keen to bank the value of this change to the logo and make the associated minimal changes from that point to incorporate the logo elsewhere. We're slowing spinning up in the space of looking at an iris and scitools documentation refresh, and I see the logo change as a decent tangible catalyst for that change.

@bjlittle bjlittle reopened this Sep 23, 2019
@SciTools-assistant SciTools-assistant removed the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Sep 23, 2019
@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@bjlittle bjlittle merged commit c4791b1 into SciTools:master Sep 23, 2019
@kaedonkers
Copy link
Member

I'll drop them off on Friday

stickers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants