Fix Travis doctests error handling. #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some time ago we stopped Travis reporting various test errors,
The problem is that the various test operations occur in groups of commands joined by ";" and Travis only checks the final RC value. So by wrapping a test in cd-in and -out commands
( e.g.
"cd my/inner/dir; test; cd ../../..")we have masked any errors that the test raises !
So, this fixes that.
At present we are failing on both a doctest and the whatsnew-aggregation check.
Those need fixing separately.
So it will make sense to merge this with the "doctest" check failing
P.S.
I also changed the order of the test matrix, so it runs "TEST_TARGET=coding" first.
I think it makes sense to get the earliest possible warning of pep8/header failures, which is after all what this target was added for. Also to run "minimal" before "full" for the same reason.
This is particularly desirable since we restricted the number of cpus so that Travis is no longer starting all the targets at once.