broke some rules #2782
broke some rules #2782
Conversation
|
WIP: This PR needs some rethinking and reworking, so I am putting it on hold for now. |
|
@corinnebosley I see that this Pull Request is addressing #2675 by removing FunctionRule. Several of my Pull Requests have removed small parts of FunctionRule, could these cause conflicts or simplify the issue slightly? The Pull Requests are #2791, #2794 and #2796 . In each case I have removed a small deprecated class from lib/iris/fileformats/rules.py and some elif statements in FunctionRule._process_action_result . Each of the Pull Requests pass all tests locally, so FunctionRule._process_action_result is clearly still able to function without the if statements I remove. From memory I can remove the deprecated classes without touching FunctionRule at all; it's just there'll be some if statements left in it which will do nothing. |
corinnebosley
force-pushed
the
dep_rules_rules_rules
branch
from
6a16951 to
79bf7a8
Compare
|
@dkillick This morning I have also removed 'Rule' and 'RuleResult' from this module as they were also part of the deprecated rules text-file process. |
corinnebosley
force-pushed
the
dep_rules_rules_rules
branch
from
a9a0fa7 to
ffcc48a
Compare
|
|
||
|
|
||
| # A flag to control all the text-rules and rules-logging deprecation warnings. | ||
| _enable_rules_deprecations = True |
There was a problem hiding this comment.
We'll need to remove this (and the following function) at some point... but not here. How about in #2670?
|
This PR had to wait a little to get merged! Good job @corinnebosley |
4 participants
Removed deprecated classes from iris.fileformats.rules.py:
Rule
FunctionRule
ProcedureRule
RulesContainer