Use matplotlib default settings for tests #2746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
added
the
Blocked: CLA needed
|
Travis failure is due to timeouts. |
|
Good idea. 👍 Incidentally, I added you to the list that we cross-check for CLA signatures in SciTools/scitools.org.uk#162, so the CLA checker should go green now 😄 |
pelson
added
Blocked: CLA needed
pelson
approved these changes
Aug 21, 2017
pelson
removed
the
Blocked: CLA needed
|
Merging even though failing with Timeouts. #2756 should now have fixed the timeouts, so rebasing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently when running the Iris tests locally, I have had a lot of errors of the form
AssertionError: Image comparison failed: Bad phash. It took me a while to realise that this was because I've setimage.cmapandaxes.prop_cyclein mymatplotlibrcfile, so the colours were wrong according to the plotting tests.This very minor change forces the tests to use the matplotlib default settings, so the above issue doesn't come up.