Faster masked array creation in DataManager. #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
ghost
assigned
Member
|
You could also patch https://github.com/SciTools/iris/blob/master/lib/iris/_merge.py#L1153, which has the same problem. |
Member
Author
|
Thanks for the top-tip @bjlittle :-) |
Member
Author
|
Hi @pp-mo - I've tweaked things as discussed, so I think this is now good to go. |
Member
|
Hi @rhattersley |
Member
Author
|
Thanks @pp-mo - please merge when you've had time to run the merged tests. |
Member
|
All tested ok |
pp-mo
added a commit
that referenced
this pull request
Nov 28, 2012
Faster masked array creation in DataManager.
Member
Author
Indeed it does. That was brought in with #210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
data.mask = Trueis surprisingly slow ... so this PR avoids it. Happy days.(The corresponding patch to NumPy is numpy/numpy#2760.)