Skip to content

Conversation

esc24
Copy link
Member

@esc24 esc24 commented Sep 25, 2012

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it your intention that this will always be the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I found limiting the extent in a general, robust way was non trivial.

@pelson
Copy link
Member

pelson commented Sep 25, 2012

I think this is really neat, nice work!

Some observations:

  • Could do with a couple more comments to explain the high level strategy at certain blocks of code
  • Docs should clarify that, in reality, you would only want to do this if you cannot visualise the data directly (i.e. you have 2d lons and lats). For most other cases, cartopy should just handle it.
  • I would love to see a visual test (might need to rebase to get those).

Apart from those, +1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. This looks to be a duplicate of @bblay's CoordSystem <-> CRS conversion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is that code? I had a look in case someone had done it, but could only find a single method on the OSGB projection class.

@esc24
Copy link
Member Author

esc24 commented Sep 26, 2012

@bblay and @pelson - the visual test work is great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no explanation of what this keyword is for. Why do we need this when we can get it from the cube?

@bblay
Copy link
Contributor

bblay commented Oct 2, 2012

Just one outstanding issue for me: the shared array discussion, above

@pelson
Copy link
Member

pelson commented Oct 2, 2012

Looks great! +1

The only missing step is the ability for users to actually plot their newly created cube without having to manually get hold of the coordinates and data. @esc24 : do you have anything in the pipeline for this?

@esc24
Copy link
Member Author

esc24 commented Oct 2, 2012

@pelson - That's is certainly the plan. I'll do it as soon as the pycarto++ branch is merged and things have settled down.

@pelson
Copy link
Member

pelson commented Oct 3, 2012

That's is certainly the plan. I'll do it as soon as the pycarto++ branch is merged and things have settled down.

Good idea. My opinion is that we should be targeting this functionality for 1.0. Given the time-scales, do you think that is achievable?

@pelson
Copy link
Member

pelson commented Oct 3, 2012

Needs an entry in the CHANGELOG and then I will merge with pleasure.

rhattersley added a commit that referenced this pull request Oct 4, 2012
Added cube project function to iris.analysis.cartography
@rhattersley rhattersley merged commit 7739392 into SciTools:master Oct 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants