-
Notifications
You must be signed in to change notification settings - Fork 296
Added cube project function to iris.analysis.cartography #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/iris/analysis/cartography.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it your intention that this will always be the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I found limiting the extent in a general, robust way was non trivial.
I think this is really neat, nice work! Some observations:
Apart from those, +1. |
lib/iris/analysis/cartography.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. This looks to be a duplicate of @bblay's CoordSystem <-> CRS conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is that code? I had a look in case someone had done it, but could only find a single method on the OSGB projection class.
lib/iris/analysis/cartography.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no explanation of what this keyword is for. Why do we need this when we can get it from the cube?
Just one outstanding issue for me: the shared array discussion, above |
Looks great! +1 The only missing step is the ability for users to actually plot their newly created cube without having to manually get hold of the coordinates and data. @esc24 : do you have anything in the pipeline for this? |
@pelson - That's is certainly the plan. I'll do it as soon as the pycarto++ branch is merged and things have settled down. |
Good idea. My opinion is that we should be targeting this functionality for 1.0. Given the time-scales, do you think that is achievable? |
Needs an entry in the CHANGELOG and then I will merge with pleasure. |
Added cube project function to iris.analysis.cartography
No description provided.