-
Notifications
You must be signed in to change notification settings - Fork 296
Closed
Labels
Feature: Merge/ConcatenatePeloton 🚴♂️Target a breakaway issue to be caught and closed by the pelotonTarget a breakaway issue to be caught and closed by the pelotonStatus: Duplicate
Description
This discussion highlighted that variable names loaded from NetCDF files are used in the comparison of candidate cubes during merge.
Variable names are not semantic containers, they are just labels, and should not be treated in this way. This needs to be implemented for cubes and coordinates, both exhibit the behaviour.
Update merge such that it:
- preserves 1 variable name if it is consistent across all candidate cubes/coordinates
- removes variable names from candidate cubes/coordinates if they differ, enabling merging to occur
Test suggestion: slice a cube into a cubelist and save the cubelist as a NetCDF file. Load the NetCDF file and assert that the merge result in 1 cube, ignoring the differing variable names.
Metadata
Metadata
Assignees
Labels
Feature: Merge/ConcatenatePeloton 🚴♂️Target a breakaway issue to be caught and closed by the pelotonTarget a breakaway issue to be caught and closed by the pelotonStatus: Duplicate