Skip to content

Use 3-arg ldiv! #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Use 3-arg ldiv! #81

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02718a6
Use 3-arg `ldiv!`
simonbyrne Dec 21, 2021
1b9e40f
define funny overload
simonbyrne Dec 21, 2021
deebf3b
Update src/factorization.jl
ChrisRackauckas Dec 22, 2021
c61b014
Add comment
simonbyrne Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/factorization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
_ldiv!(x, A, b) = ldiv!(x, A, b)
function _ldiv!(x::Vector, A::Factorization, b::Vector)
# workaround https://github.com/JuliaLang/julia/issues/43507
copyto!(x, b)
ldiv!(A, x)
end


function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization; kwargs...)
if cache.isfresh
fact = do_factorization(alg, cache.A, cache.b, cache.u)
cache = set_cacheval(cache, fact)
end

copyto!(cache.u,cache.b)
y = ldiv!(cache.cacheval, cache.u)
y = _ldiv!(cache.u, cache.cacheval, cache.b)
SciMLBase.build_linear_solution(alg,y,nothing,cache)
end

Expand Down