Aqua + typos CI #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ArnoStrouwen wants to merge 2 commits into SciML:master from ArnoStrouwen:qa

Member

ArnoStrouwen commented Dec 3, 2023

I don't understand the unbound args error in this one.


          Aqua + typos CI

Member Author

ArnoStrouwen commented Jan 5, 2024

Bumping this.
https://github.com/SciML/LabelledArrays.jl/actions/runs/7075146407/job/19256954357?pr=150#step:6:446
How does this function work for LArrays? The S type parameter won't exist then.
https://github.com/SciML/LabelledArrays.jl/blob/master/src/larray.jl#L370


          fix unbound type parameter

91e3a6d

ArnoStrouwen force-pushed the qa branch from 7ee2c5b to 91e3a6d Compare

January 5, 2024 04:10

Member

ChrisRackauckas commented Jan 6, 2024

It's the same as the conversion of arrays to staticarrays. It should probably just be done in a separate dispatch, using size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet