feat: add get_updated_symbolic_problem
#1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should do the same in |
|
Wouldn't that do double the work for algorithms that call |
|
No it won't because of how the problems recurse. But I just realized that where this makes sense is actually in |
|
Wouldn't |
|
Well this is updating the u0 though? But yes, it's part of the concretization process. |
src/solve.jl
Outdated
| prob | ||
| end | ||
|
|
||
| function get_concrete_problem(prob::SteadyStateProblem, isadapt; kwargs...) | ||
| p = get_concrete_p(prob, kwargs) | ||
| u0 = get_concrete_u0(prob, isadapt, Inf, kwargs) | ||
| u0 = promote_u0(u0, p, nothing) | ||
| remake(prob; u0 = u0, p = p) | ||
| prob = remake(prob; u0 = u0, p = p) | ||
| get_updated_symbolic_problem(_get_root_indp(prob), prob) |
There was a problem hiding this comment.
why is this after the remake and promotions? This should go up before promote_u0
There was a problem hiding this comment.
Oh hm. Yeah in my head I thought if we do it after promotions MTK knows the type to use but of course that is backward. We should let MTK populate the values and then promote to the correct type after.
…m` instead of `init_call`
AayushSabharwal
force-pushed
the
as/pre-solve-hook
branch
from
2f527fa to
8140ed7
Compare
ChrisRackauckas
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a better place to call this than
init_call?