Skip to content

Some maintenance #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

Some maintenance #9

wants to merge 23 commits into from

Conversation

williamdes
Copy link

  • Added a .gitattributes file (e9f87c4)
  • Add some approximate PHP requirements (a1dcbf1)
  • Added some links to composer.json (81531b7)
  • Removed useless comments from source files (d931371)

@williamdes
Add a .gitattributes file
e9f87c4 
Just exclude some non usefull files from vendor tarballs
And exclude a future .github folder
@williamdes
Add some approximate PHP requirements
a1dcbf1
@williamdes
Add cool links to composer.json
81531b7
@williamdes
Clean source files
d931371
@williamdes
Copy link
Author

Relates to #8

@williamdes
Copy link
Author 

williamdes@williamdes:/mnt/Dev/@code-lts/U2F-php-server$ composer run phpunit
> ./vendor/bin/phpunit
PHPUnit 9.4.2 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 00:00.002, Memory: 6.00 MB

OK (1 test, 1 assertion)

The useless test works, another day will be implementation day !

@williamdes
Improvements to README.md
779225d 
- Remove uses of compact function
- Improve commands highlighting
- Improve links
- Use HTTPS everywhere
- Replace double by single quotes
- Use a better licence URL than a fixed one
- Fix a typo
@williamdes
Use new PHP bracket style
74a20fd
@williamdes
Update phpdocs
7640e67
@williamdes
Fix README links
cdbc30b
@williamdes
Add a test case for Samyoul#6
b21bc14
@williamdes
Add a test workflow
7aab0a2
@williamdes
Make test compatible with all phpunit supported versions
ee6d8c4
@williamdes williamdes mentioned this pull request Oct 30, 2020
Open
@williamdes
Add a test for fixSignatureUnusedBits
f9c78ff 
I spent many hours finding&searching for CA certs online..
Please be nice and reference this as source.
@williamdes
Add a usefull comment found on another implementation
9ff9763
@williamdes
Improve phpdoc return type for makeAuthentication
41f389c
@williamdes
Add more tests
cf7fae5
@williamdes
Improve phpdoc return for makeRegistration
46a4200
@williamdes
Ignore build files
3622240
@williamdes
Improve phpdoc for get_certs and register
cf16851
@williamdes
Add more tests
4a63bbc 
Code Coverage Report:      
  2020-11-02 14:18:07      
                           
 Summary:                  
  Classes: 60.00% (3/5)    
  Methods: 83.33% (25/30)  
  Lines:   76.29% (148/194)

Samyoul\U2F\U2FServer\Registration
  Methods: 100.00% ( 7/ 7)   Lines: 100.00% ( 10/ 10)
Samyoul\U2F\U2FServer\RegistrationRequest
  Methods: 100.00% ( 5/ 5)   Lines: 100.00% (  9/  9)
Samyoul\U2F\U2FServer\SignRequest
  Methods:  83.33% ( 5/ 6)   Lines:  91.67% ( 11/ 12)
Samyoul\U2F\U2FServer\U2FException
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
Samyoul\U2F\U2FServer\U2FServer
  Methods:  63.64% ( 7/11)   Lines:  72.05% (116/161)
@williamdes williamdes marked this pull request as ready for review November 2, 2020 14:18
@williamdes
Copy link
Author

williamdes commented Nov 2, 2020 •
edited
Loading

Hi @Samyoul
Review can start, here is a coverage report. I am near to be finished, some exceptions to test.
composer run phpunit -- --coverage-text

Code Coverage Report:      
  2020-11-02 18:00:32      
                           
 Summary:                  
  Classes: 80.00% (4/5)    
  Methods: 86.67% (26/30)  
  Lines:   86.98% (167/192)

Samyoul\U2F\U2FServer\Registration
  Methods: 100.00% ( 7/ 7)   Lines: 100.00% ( 10/ 10)
Samyoul\U2F\U2FServer\RegistrationRequest
  Methods: 100.00% ( 5/ 5)   Lines: 100.00% (  9/  9)
Samyoul\U2F\U2FServer\SignRequest
  Methods: 100.00% ( 6/ 6)   Lines: 100.00% ( 12/ 12)
Samyoul\U2F\U2FServer\U2FException
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
Samyoul\U2F\U2FServer\U2FServer
  Methods:  63.64% ( 7/11)   Lines:  84.28% (134/159)

@williamdes
Add more tests and clear the values
0cab4ce 
Code Coverage Report:      
  2020-11-02 17:00:32      
                           
 Summary:                  
  Classes: 80.00% (4/5)    
  Methods: 86.67% (26/30)  
  Lines:   86.98% (167/192)

Samyoul\U2F\U2FServer\Registration
  Methods: 100.00% ( 7/ 7)   Lines: 100.00% ( 10/ 10)
Samyoul\U2F\U2FServer\RegistrationRequest
  Methods: 100.00% ( 5/ 5)   Lines: 100.00% (  9/  9)
Samyoul\U2F\U2FServer\SignRequest
  Methods: 100.00% ( 6/ 6)   Lines: 100.00% ( 12/ 12)
Samyoul\U2F\U2FServer\U2FException
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
Samyoul\U2F\U2FServer\U2FServer
  Methods:  63.64% ( 7/11)   Lines:  84.28% (134/159)
@williamdes
Copy link
Author

Hello @Samyoul

Could you let me know if this pull-request has some hope to be merged ?

@williamdes williamdes mentioned this pull request Jan 25, 2021
Closed
@williamdes williamdes deleted the branch Samyoul:master December 12, 2021 09:29
@williamdes williamdes closed this Dec 12, 2021
@williamdes williamdes deleted the master branch December 12, 2021 09:29
@williamdes
Copy link
Author

This is all in https://github.com/code-lts/U2F-php-server now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@williamdes