Skip to content

[LAB1] m091545 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

[LAB1] m091545 #8

merged 2 commits into from
Mar 7, 2024

Conversation

@quan0715
Copy link

@quan0715 quan0715 commented Feb 29, 2024 •
edited by AlaRduTP
Loading

Description

add tests for main.js

#2

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI
  • Add proper label for this PR

@quan0715 quan0715 changed the title [lab1]m091545 [LAB1] m091545 Feb 29, 2024
@AlaRduTP AlaRduTP added the lab1 label Feb 29, 2024
@TaiYou-TW
Copy link
Contributor

TaiYou-TW commented Mar 7, 2024

Remember to develop on your own branch next time.

@TaiYou-TW TaiYou-TW merged commit 6dd3735 into SQLab:m091545 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lab1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quan0715 @TaiYou-TW @AlaRduTP