Skip to content

[LAB1] 312552050 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

[LAB1] 312552050 #35

merged 2 commits into from
Mar 7, 2024

Conversation

@tsaiet
Copy link

@tsaiet tsaiet commented Feb 29, 2024 •
edited
Loading

Description

#2

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW closed this Feb 29, 2024
@TaiYou-TW TaiYou-TW reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
@tsaiet tsaiet changed the title [Lab1] 312552050 [LAB1] 312552050 Mar 7, 2024
@TaiYou-TW
Copy link
Contributor

TaiYou-TW commented Mar 7, 2024

You should use more meaningful messages on your commits next time.

@TaiYou-TW TaiYou-TW merged commit 6c3bef3 into SQLab:312552050 Mar 7, 2024
@tsaiet
Copy link
Author

tsaiet commented Mar 8, 2024

You should use more meaningful messages on your commits next time.

okay!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lab1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsaiet @TaiYou-TW