WebPCoder now supports the thumbnail decoding #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
changed the title
dreampiggy
changed the title
dreampiggy
force-pushed
the
feature_thumbnail_decoding
branch
from
64b24a0 to
531a096
Compare
…ause the draw frame contains Jagged and buggy. Instead, use the full pixels canvas to draw, scale down each frame after drawn (sadlly)
dreampiggy
force-pushed
the
feature_thumbnail_decoding
branch
2 times, most recently
from
18e46b3 to
4152405
Compare
|
I previously enter the trap, to use the thumbnail pixel count to create a canvas and draw, however, this is wrong. For Animated WebP, we must always use the full pixel count canvas, draw each frame to follows WebP standard. This canvas RAM usage can not been saved. This is because, each frame contains the offset and size to place, however, if we scaled them down, some edge will loss details, the final blend on the canvas will cause glitch.... A little suck :( See the video about what I means (using the smaller canvas to draw): Animated WebP Bug when using smaller canvas.mov.zip So, finally, I have to use |
dreampiggy
force-pushed
the
feature_thumbnail_decoding
branch
from
4152405 to
6726339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See thumbnail decoding PR: SDWebImage/SDWebImage#2922