Skip to content

Conversation

@pabloitu
Copy link
Collaborator

@pabloitu pabloitu commented Aug 20, 2024

closes #264

fix: changed scipy.integrate.cumtrapz import by cumulative_trapezoid …in plots.py module

pyCSEP Pull Request Checklist

Fixes issue #264.

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@pabloitu pabloitu requested a review from fabiolsilva August 20, 2024 02:34
@pabloitu
Copy link
Collaborator Author

Minor change. Results check out neatly with old figs (running examples/tutorials/gridded_forecast_evaluation)

@fabiolsilva fabiolsilva self-assigned this Aug 23, 2024
Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code to fix cumtrapz dependency error with newer SciPy versions.

@fabiolsilva fabiolsilva merged commit 62d50c7 into SCECcode:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with importing scipy.integrate.cumtrapz

2 participants