Skip to content

digest v0.11 #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 19, 2022
Merged

digest v0.11 #1173

merged 11 commits into from
Dec 19, 2022

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Dec 19, 2022 •
edited
Loading

Depends on #1172 and RustCrypto/utils#823

Closes #1027

Changed

  • crypto-common dependency bumped to v0.2
  • Edition changed to 2021 and MSRV bumped to 1.57

Removed

  • Mac::new, Mac::new_from_slice, and Mac::generate_key methods

@newpavlov
Copy link
Member Author

@tarcieri
Regarding #1027. Do you think we should simply remove Mac::new and instead tell users to rely on KeyInit::new?

@tarcieri
Copy link
Member

@newpavlov yes, sounds good to me

@tarcieri
Copy link
Member

It'd probably also be good to leave this at -pre too to allow additional breaking changes (like a hybrid-array migration)

@newpavlov
Copy link
Member Author

I temporarily removed -pre to make it easier to prototype RustCrypto/hashes#444.

@newpavlov newpavlov mentioned this pull request Dec 19, 2022
Closed
@newpavlov newpavlov merged commit 9bf4bf8 into master Dec 19, 2022
@newpavlov newpavlov deleted the digest_v0.11 branch December 19, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplication / confusion between KeyInit::new and digest::Mac::new
2 participants
@newpavlov @tarcieri