Update elliptic-curve
#1257
Merged
Update elliptic-curve
#1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
tarcieri
reviewed
Jun 13, 2025
| } | ||
|
|
||
| impl<C> group::Curve for ProjectivePoint<C> | ||
| impl<C> Curve for ProjectivePoint<C> |
There was a problem hiding this comment.
I used group::Curve intentionally to keep it namespaced since Curve is incredibly overloaded (really it should probably be named CurveGroup, see zkcrypto/group#51).
I guess elliptic-curve could re-export it as CurveGroup.
All that said, I guess this is fine for now and I'll follow up.
There was a problem hiding this comment.
Ah, apologies. I was importing it to be able to use it. But I can just import it as use ...::Curve as _.
Let me know if you want me to fix this up.
There was a problem hiding this comment.
Can fix it up after this: RustCrypto/traits#1902
tarcieri
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
elliptic-curveto master.This merges #1248 and #1256.