Skip to content

From<i32> for SwapInterval should be panic-less TryFrom<i32> implementation #1311

Open
@KisaragiEffective

Description

@KisaragiEffective

Hi,

I've found that your implementation of From<i32> for SwapInterval panics if the given value is out of range. However, From trait seems not intended to be used with panic; I would like to purpose replace it with TryFrom<i32> implementation (this purpose is a breaking change).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions