WIP more GIMPLE conversion #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managing blocks in the scope
This was
linked to
issues
May 21, 2020
Closed
philberty
commented
May 21, 2020
| stmt->accept_vis (*this); | ||
| } | ||
|
|
||
| auto localMap = localsPerBlock.Pop (); |
There was a problem hiding this comment.
This seems to be a C++17 thing and gcc is warning about it. Not sure if we should allow it or now. Might be something to create an issue out of for what C++ version will we limit ourselves to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial setup for the pass to convert to GIMPLE. On thing that needed done in type resolution was to find all locals per block as these must be setup up front for GIMPLE but this was easy enough with our visitor pattern.
Note the creation of a cscope.h (needs a better name) but something like this might be useful for our static analysis passes to be more unified.